-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IOS GameLoop addition #1325
Conversation
@Sloox Added temporary bash scripts:
|
Timestamp: 2020-11-24 15:44:22 |
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
============================================
- Coverage 77.83% 77.81% -0.03%
Complexity 705 705
============================================
Files 244 244
Lines 4692 4692
Branches 901 901
============================================
- Hits 3652 3651 -1
Misses 550 550
- Partials 490 491 +1 |
- model: iphone11 | ||
version: 13.6 | ||
orientation: portrait | ||
locale: en_US |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I try to run this test from Debug.kt Flank returns
Both of following options must be specified [test, xctestrun-file].
Process finished with exit code 2
- Blank line missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamfilipow92 FTL with gameloop mode doesn't need xctestrun-file,
however Flank currently requires it. @Sloox will fix this in next a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I try to run it on gcloud cli!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamfilipow92 this wont work until @jan-gogo applies a fix that will come in #1341 . However #1341 is blocked until other tickets are closed (including this one.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on gcloud cli
gcloud alpha firebase test ios run \
--type game-loop --app FlankGameLoopExample.ipa --scenario-numbers 1 \
--device model=iphone11,version=13.6
Test pass
┌─────────┬───────────────────────────┬──────────────┐
│ OUTCOME │ TEST_AXIS_VALUE │ TEST_DETAILS │
├─────────┼───────────────────────────┼──────────────┤
│ Passed │ iphone11-13.6-en-portrait │ -- │
└─────────┴───────────────────────────┴──────────────┘
* scripts for archive/export IPA for ios game loop * scripts for creating test artifacts for iOS Multiple test targets example (test plans)
2d36a20
to
07672a8
Compare
This PR adds iOS example project with a game loop.
Scripts for generating IPA file from iOS source code will be added in:
#1345
Support for game loop in Flank will be fully implemented in:
#1341
Test Plan
.
Checklist
Bottom note: Flank doesn't support gameloop mode for iOS yet.
Flank requires xctestrun-file which doesn't exist in gameloop mode. #1341